Webapp Angular upgrade 15 to 16#7056
Conversation
…atibility Angular 16. Path updates in libraries and new package.lock
…ons bazel and patchbuild tool
| deps = [ | ||
| "@npm//@babel/core", | ||
| "@npm//@babel/helper-annotate-as-pure", | ||
| + "@npm//@babel/helper-split-export-declaration", |
There was a problem hiding this comment.
Only change in this file. The newer version of @angular-devkit/build-angular: 15.2.11 (resolved in yarn.lock) explicitly added @babel/helper-split-export-declaration as its own dependency. The BUILD.bazel for the optimization scripts can not find it, so needs to be added.
| - if getattr(ctx.attr, "use_angular_plugin", False): | ||
| - closure_js_files.append(ctx.actions.declare_file(basename + ".ngfactory.mjs")) | ||
| - closure_js_files.append(ctx.actions.declare_file(basename + ".ngsummary.mjs")) | ||
| - |
There was a problem hiding this comment.
In this Angular version Ivy is already available so these lines can be removed. @todos resolved.
There was a problem hiding this comment.
Do you think we should try to upgrade @bazel/concatjs to avoid having to maintain this patch file? Low priority -- im fine with this as it is now but it might be sort of kicking a can down the road that we can avoid if we just upgrade.
| "@npm//:node_modules/zone.js/dist/zone-testing.js", | ||
| "@npm//:node_modules/zone.js/bundles/zone.umd.js", | ||
| "@npm//:node_modules/zone.js/bundles/zone-testing.umd.js", | ||
| "@npm//:node_modules/reflect-metadata/Reflect.js", |
There was a problem hiding this comment.
New paths for zone.js
Motivation for features / changes
This PR is the first step in a planned major Angular upgrade cycle, where each major version will be delivered in a separate PR, incrementally progressing until the project reaches Angular 20.
This specific PR upgrades TensorBoard from Angular 15 to Angular 16, initiating the migration path toward Angular 20+.
Keeping the framework and aligned dependencies (NgRx, TypeScript, RxJS, zone.js, etc.) up to date ensures continued compatibility, security support, and maintainability, while preparing the project for future Angular features and ecosystem improvements.
Technical description of changes
Upgrade the TensorBoard web application from Angular 15 to Angular 16 following TensorBoard’s DEVELOPMENT.md guidelines and the official Angular migration guide.
Detailed steps to verify changes work correctly (as executed by you)